Default scope for events and callbacks

[Dave Stewart]

Is there a way to set a default scope?

I generally don't use the onScope properties in Tween or TimelineMax, rather I bind my functions as I pass them in:

function onComplete()
{
  // do something here
}

var tl = new TimelineMax({onComplete:onComplete.bind(this)});

However, I've also got a fair few callbacks I'm using in the animation, and the .this is common to all of them, which is my Scene object.

 

It would be really useful to do something like this, rather than any of the options above:

function onComplete()
{
  console.log(this);
}

function callback()
{
  console.log(this);
}

var tl = new TimelineMax({onComplete:onComplete, defaultScope:this});
tl
  .to('#box', 2, {alpha:1})
  .call(callback);

Is that possible right now, or could it be implemented?

 

Cheers,

Dave

[Dave Stewart]

Took a look at the GitHub source and it looks like this could be implemented really easily, for example:

this._onUpdate.apply(this.vars.onUpdateScope || this.vars.onDefaultScope || this, this.vars.onUpdateParams || _blankArray);

[Dave Stewart]

OK, have forked, updated, and submitted a pull request:

 

https://github.com/greensock/GreenSock-JS/pull/56

 

Be sure to check the "defaultScope" branch.

 

Appears to be working happily on:

• onStart
• onUpdate
• onRepeat
• onComplete
• onReverseComplete
• addPause()
• call()

 

Did I miss anything?

 

Cheers,

Dave

[Carl]

Hi Dave,

 

Thanks for the suggestion and for digging in to offer a solution.

We probably won't be able to look at this closely until after the holiday weekend.

[Dave Stewart]

Oh yes!

 

Happy You Kicked Our Asses 300 Years Ago Day

 

Enjoy.