Remember AdHelper.js? Issue with 'sleep' and 'wake'

[Brandon Marsh]

Hello! My first post here, hopefully somebody can help. I'm doing some small banner work that includes AdHelper.js that Grant Skinner wrote a long time ago (See here: https://github.com/CreateJS/html5ads/tree/master/AdHelper) . I'm getting some errors on the following functions. Specifically, I'm getting errors for the following lines:

 

var originalFrame = ticker.frame; //record the original frame temporarily so we can revert

Error for above line:

Cannot read properties of undefined (reading 'frame')

 

It appears that when console.log'ing (ticker), that it's undefined. It looks like nothing should be 'wrong', and that it should be reading GSAP's .ticker, but I'm not sure why I'm getting undefined here. I know this code was definitely written a long time ago, so I have a suspicion that it's something small I'm doing wrong.

 

Not sure what the solution is here, but any help would be greatly appreciated. 

 

	p._sleep = function() {


		if (!this.awake) { return; }
		createjs.Ticker.paused = true;
		if (this.tickListener) { createjs.Ticker.removeEventListener("tick", this.tickListener); }
		window.TweenLite && TweenLite.ticker && TweenLite.ticker.sleep();
		this.dispatchEvent("sleep");
		this.awake = false;

	};

	p._wake = function() {
		if (this.awake) { return; }
		createjs.Ticker.paused = false;
		if (this.tickListener) { createjs.Ticker.addEventListener("tick", this.tickListener); }
	
		if (window.TweenLite) {
			var ticker = TweenLite.ticker;
			console.log(ticker);
			var originalFrame = ticker.frame; //record the original frame temporarily so we can revert
			ticker.frame = 1; //hack to make legacy versions of GSAP apply lag smoothing upon wake
			ticker.wake(true);
			ticker.frame = originalFrame;
		}

 

[GreenSock]

Hi @Brandon Marsh. Welcome. 

 

Yeah, we definitely can't support AdHelper or troubleshoot code in another library that GreenSock didn't create. It looks like you're using TweenLite which is a relic from the very old GSAP - there's a much more modern syntax that does away with TweenLite/TweenMax/TimelineLite/TimelineMax. See

 

I suspect that maybe the problem is that the code is referencing TweenLite.ticker which should be gsap.ticker.

 

Good luck!

[Brandon Marsh]

Thanks Jack. No problem at all. I did try to change Tweenlite to gsap but still ran into the undefined error. I bet it has something to do with scope. Nevertheless it's not a world ending issue. I will do some digging and try to fix it, and if I do I will report back on here. 

 

Thanks for the quick reply.

[GreenSock]

Yeah, it's pretty tough to troubleshoot blind but I'm surprised you're getting the same error if you corrected TweenLite.ticker to be gsap.ticker. Are you loading a recent version of GSAP? 

 

If you still need help, please post a minimal demo that clearly shows the error and we'll take a peek.