onStart not firing on empty TimelineMax

[erikb 28 Likes (Newbie)]

Came across a snag -- an empty TimelineMax does not fire its onStart events, but does fire its onComplete events.

 

In contrast to this  example:

See the Pen eZPGrb by jedierikb (@jedierikb) on CodePen

 

Is this a bug?  It seems like it might be.  

 

(I am dynamically making tweens based on incoming data, hence the perhaps odd discovery )

See the Pen EKdwoJ by jedierikb (@jedierikb) on CodePen

[Carl 11,115 Likes (Superhero)]

Regarding the empty timeline, I imagine Jack will chime in with more specifics, but I believe it can be argued that it never started. It doesn't have a duration or any child tweens. However, perhaps it completes based soley on the fact that the root timeline passed over the point in time where the complete callback should be fired.

 

Then again it might be a bug. I think its tough to really say what one should expect when dealing with an animation that has no duration.

 

To get the results you want, for now you could just add a callback at time(0) like:

 

var tm = new TimelineMax({
  onComplete: completeThing
});


tm.call(startThing)

[GreenSock 18,293 Likes (Superhero)]

I can see valid arguments on both sides. Ultimately I do lean slightly toward making onStart fire in this case. If anyone disagrees, please chime in. I've made that update in the 1.18.5 preview which you can check (uncompressed) here: https://s3-us-west-2.amazonaws.com/s.cdpn.io/16327/TweenMax-latest-beta.js Better? 

[erikb 28 Likes (Newbie)]

Thanks for this patch.  I will be able to test it next week.

[erikb 28 Likes (Newbie)]

I can see valid arguments on both sides. Ultimately I do lean slightly toward making onStart fire in this case. If anyone disagrees, please chime in. I've made that update in the 1.18.5 preview which you can check (uncompressed) here: https://s3-us-west-2.amazonaws.com/s.cdpn.io/16327/TweenMax-latest-beta.js Better? 

 

Looks good.  Thanks.

See the Pen pyYXQa by jedierikb (@jedierikb) on CodePen