For loop returning incorrect counter number

[pdiddles03]

I'm working on a game. Inside of it, i have an array which gets loop through using a for loop and if each object is not being tweened, it tweens them to a specific position like this:

if(ship.active_bullets.length > 0){
        for(var i = 0; i < ship.active_bullets.length; i++){
          if(ship.active_bullets[i]){
            if(TweenMax.isTweening(ship.active_bullets[i])===false){
              TweenMax.to(ship.active_bullets[i], 2*scale, {y:0,ease:Power0.easeNone,onComplete:function(){
                console.log(i)
                
              }});
            }
          }
        }
      }

The output in the console on complete is then number 1 instead of 0 which is what it is before the tween. why is this?

[pdiddles03]

I did seem to solve the issue by doing this but I don't feel this is a very convenient way of doing it. Seeing I am writing a game, it adds unnecessary bloat to it.

if(ship.active_bullets.length > 0){
        for(var i = 0; i < ship.active_bullets.length; i++){
          if(ship.active_bullets[i]){

            if(TweenMax.isTweening(ship.active_bullets[i])===false){
              (function(i){
                TweenMax.to(ship.active_bullets[i], 2*scale, {y:0,ease:Power0.easeNone,onComplete:function(){
                  
                }});
              })(i)

            }
          }
        }
      }

[Carl]

Hi and welcome to the GreenSock forums,

 

Hmm, it seems like the loop is working properly just not as you would wish.

By the time your onComplete callbacks run i has already been incremented to its highest value.

 

It really helps if you could provide a reduced sample, but I think using onCompleteParams will help:

 

for (var i = 0; i < 3; i++)
  TweenLite.to("#box" + i, 0.2, {
    x: 100,
    onComplete: function(n) {
      console.log(n) //0, 1, 2
    },
    onCompleteParams:[i]
  })

 

http://codepen.io/GreenSock/pen/mEWqWR?editors=0011

[pdiddles03]

Exactly what i needed! I didn't know there was oncompleteparams! Thank You!

[OSUblake]

As Carl just demonstrated, you have to capture that value before the next loop. Notice how the buttons are labeled correctly but logging the wrong value. 

See the Pen XmBPdO?editors=0011 by osublake (@osublake) on CodePen

 
If you're worried about bloat, use your array. Your code can be reduced to 2 lines of code.

activeBullets
  .filter(function(bullet) { return !TweenMax.isTweening(bullet); })
  .forEach(function(bullet) { TweenLite.to(bullet, 1, { y: 0 }); }); 

Time to do some bullet/rocket spawning...

See the Pen 0d7684be69769aa4edc1d69d01a9a86f?editors=0010 by osublake (@osublake) on CodePen