ticker missing callbacks when adding callbacks on a callback

[erikb 28 Likes (Newbie)]

Ran into an issue this evening.

 

If adding a callback to the ticker during a different ticker callback, there is a chance the ticker will miss some of the callbacks already scheduled.

 

In the console output for the pen, notice that a callback with priority 1 is skipped on frame 30.

 

I have implemented a hotfix of my own for this issue by modifying the TweenMax source for dispatchEvent.  I clone the list with a list.slice(0); before iterating through it.   New listeners will not be added until the next tick, but that is understandable behavior.

 

Thanks for looking into this.

See the Pen GqJadb?editors=0010 by jedierikb (@jedierikb) on CodePen

[erikb 28 Likes (Newbie)]

My fix (for now... would like to be on the main release branch again)

https://github.com/jedierikb/GreenSock-JS/commit/f10a7828f7f8c62271d8909e649e7988e4cd501b

[GreenSock 18,243 Likes (Superhero)]

I see what you mean, but that's only necessary if the length is greater than 1. Skipping it in that case (1) allows us to improve performance for the vast majority of users (when people don't add extra "tick" listeners). https://s3-us-west-2.amazonaws.com/s.cdpn.io/16327/TweenMax-latest-beta.js